android_webview/browser/icon_helper.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index cc5ae4211c8b8f4cc74d3f1c0e856ef8011b38e3..8922a7eeb0b6c016ab91dbd3e400991561552473 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -57,7 +57,7 @@ void IconHelper::DownloadFaviconCallback(

listener_->OnReceivedIcon(image_url, bitmaps[0]);

}

-void IconHelper::DidUpdateFaviconURL(int32 page_id,

+void IconHelper::DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

for (std::vector<content::FaviconURL>::const_iterator i = candidates.begin();

« no previous file with comments | « android_webview/browser/icon_helper.h ('k') | apps/app_window.h » ('j') | no next file with comments »