content/shell/browser/shell_devtools_frontend.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_devtools_frontend.cc

diff --git a/content/shell/browser/shell_devtools_frontend.cc b/content/shell/browser/shell_devtools_frontend.cc

index 6d0e1f0102f1acd39634f2d6856c75d68fd5cdfe..92bdc9ad0577d2ed04c4a59f06697ee23a13ac01 100644

--- a/content/shell/browser/shell_devtools_frontend.cc

+++ b/content/shell/browser/shell_devtools_frontend.cc

@@ -121,7 +121,7 @@ void ShellDevToolsFrontend::RenderViewCreated(

frontend_host_.get());

}

-void ShellDevToolsFrontend::DocumentOnLoadCompletedInMainFrame(int32 page_id) {

+void ShellDevToolsFrontend::DocumentOnLoadCompletedInMainFrame() {

web_contents()->GetMainFrame()->ExecuteJavaScript(

base::ASCIIToUTF16("InspectorFrontendAPI.setUseSoftMenu(true);"));

}

« no previous file with comments | « content/shell/browser/shell_devtools_frontend.h ('k') | no next file » | no next file with comments »