content/public/browser/notification_types.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/notification_types.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/notification_types.h

diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h

index a2849893f5e4c1957968f6e2205f86c050759599..08ffd3306deb7b45e2e9abae753aa9ecf0b7ddbf 100644

--- a/content/public/browser/notification_types.h

+++ b/content/public/browser/notification_types.h

@@ -72,7 +72,7 @@ enum NotificationType {

// Other load-related (not from NavigationController) ----------------------

// Corresponds to ViewHostMsg_DocumentOnLoadCompletedInMainFrame. The source

- // is the WebContents and the details the page_id.

+ // is the WebContents.

// DEPRECATED: Use WebContentsObserver::DocumentOnLoadCompletedInMainFrame()

NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,