content/renderer/render_frame_impl.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index a37eecf70bc9ce305d93987dd07334890e762cc9..a507a3997e5a9c99555bbb5f98c96b9aa636de70 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2014,10 +2014,8 @@ void RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame* frame) {

void RenderFrameImpl::didHandleOnloadEvents(blink::WebLocalFrame* frame) {

DCHECK(!frame_ || frame_ == frame);

- if (!frame->parent()) {

- Send(new FrameHostMsg_DocumentOnLoadCompleted(routing_id_,

- render_view_->page_id_));

- }

+ if (!frame->parent())

+ Send(new FrameHostMsg_DocumentOnLoadCompleted(routing_id_));

}

void RenderFrameImpl::didFailLoad(blink::WebLocalFrame* frame,

« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »