content/browser/web_contents/web_contents_impl.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 4cd1943e5e5f12a58bce56a8286f343879532530..fdf8a0990e306786e023ce588c944c6228406031 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -357,8 +357,8 @@ class CONTENT_EXPORT WebContentsImpl

IPC::Message* reply_msg) OVERRIDE;

virtual void DidAccessInitialDocument() OVERRIDE;

virtual void DidDisownOpener(RenderFrameHost* render_frame_host) OVERRIDE;

- virtual void DocumentOnLoadCompleted(RenderFrameHost* render_frame_host,

- int32 page_id) OVERRIDE;

+ virtual void DocumentOnLoadCompleted(

+ RenderFrameHost* render_frame_host) OVERRIDE;

virtual WebContents* GetAsWebContents() OVERRIDE;

virtual bool IsNeverVisible() OVERRIDE;

@@ -763,9 +763,8 @@ class CONTENT_EXPORT WebContentsImpl

const GURL& image_url,

const std::vector<SkBitmap>& bitmaps,

const std::vector<gfx::Size>& original_bitmap_sizes);

- void OnUpdateFaviconURL(int32 page_id,

- const std::vector<FaviconURL>& candidates);

- void OnFirstVisuallyNonEmptyPaint(int32 page_id);

+ void OnUpdateFaviconURL(const std::vector<FaviconURL>& candidates);

+ void OnFirstVisuallyNonEmptyPaint();

void OnMediaPlayingNotification(int64 player_cookie,

bool has_video,

bool has_audio);