Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: android_webview/browser/icon_helper.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | android_webview/browser/icon_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
6 #define ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 24 matching lines...) Expand all
35 protected: 35 protected:
36 virtual ~Listener() {} 36 virtual ~Listener() {}
37 }; 37 };
38 38
39 explicit IconHelper(content::WebContents* web_contents); 39 explicit IconHelper(content::WebContents* web_contents);
40 virtual ~IconHelper(); 40 virtual ~IconHelper();
41 41
42 void SetListener(Listener* listener); 42 void SetListener(Listener* listener);
43 43
44 // From WebContentsObserver 44 // From WebContentsObserver
45 virtual void DidUpdateFaviconURL(int32 page_id, 45 virtual void DidUpdateFaviconURL(
46 const std::vector<content::FaviconURL>& candidates) OVERRIDE; 46 const std::vector<content::FaviconURL>& candidates) OVERRIDE;
47 virtual void DidStartNavigationToPendingEntry( 47 virtual void DidStartNavigationToPendingEntry(
48 const GURL& url, 48 const GURL& url,
49 content::NavigationController::ReloadType reload_type) OVERRIDE; 49 content::NavigationController::ReloadType reload_type) OVERRIDE;
50 50
51 void DownloadFaviconCallback( 51 void DownloadFaviconCallback(
52 int id, 52 int id,
53 int http_status_code, 53 int http_status_code,
54 const GURL& image_url, 54 const GURL& image_url,
55 const std::vector<SkBitmap>& bitmaps, 55 const std::vector<SkBitmap>& bitmaps,
56 const std::vector<gfx::Size>& original_bitmap_sizes); 56 const std::vector<gfx::Size>& original_bitmap_sizes);
57 57
58 private: 58 private:
59 void MarkUnableToDownloadFavicon(const GURL& icon_url); 59 void MarkUnableToDownloadFavicon(const GURL& icon_url);
60 bool WasUnableToDownloadFavicon(const GURL& icon_url) const; 60 bool WasUnableToDownloadFavicon(const GURL& icon_url) const;
61 void ClearUnableToDownloadFavicons(); 61 void ClearUnableToDownloadFavicons();
62 62
63 Listener* listener_; 63 Listener* listener_;
64 64
65 typedef uint32 MissingFaviconURLHash; 65 typedef uint32 MissingFaviconURLHash;
66 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_; 66 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
67 67
68 DISALLOW_COPY_AND_ASSIGN(IconHelper); 68 DISALLOW_COPY_AND_ASSIGN(IconHelper);
69 }; 69 };
70 70
71 } // namespace android_webview 71 } // namespace android_webview
72 72
73 #endif // ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 73 #endif // ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/icon_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698