content/browser/frame_host/render_frame_host_impl.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 69f74e2654d75cfaeab2e8db0ae8b56169254f41..f9e19e6cb70b888ff6a7c03f464086c824c1e4fb 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -359,11 +359,10 @@ void RenderFrameHostImpl::OnOpenURL(

params.should_replace_current_entry, params.user_gesture);

}

-void RenderFrameHostImpl::OnDocumentOnLoadCompleted(

- int32 page_id) {

+void RenderFrameHostImpl::OnDocumentOnLoadCompleted() {

// This message is only sent for top-level frames. TODO(avi): when frame tree

// mirroring works correctly, add a check here to enforce it.

- delegate_->DocumentOnLoadCompleted(this, page_id);

+ delegate_->DocumentOnLoadCompleted(this);

}

void RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame(