Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/shell/browser/shell_devtools_frontend.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell_devtools_frontend.h" 5 #include "content/shell/browser/shell_devtools_frontend.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 void ShellDevToolsFrontend::RenderViewCreated( 115 void ShellDevToolsFrontend::RenderViewCreated(
116 RenderViewHost* render_view_host) { 116 RenderViewHost* render_view_host) {
117 DevToolsClientHost::SetupDevToolsFrontendClient( 117 DevToolsClientHost::SetupDevToolsFrontendClient(
118 web_contents()->GetRenderViewHost()); 118 web_contents()->GetRenderViewHost());
119 DevToolsManager* manager = DevToolsManager::GetInstance(); 119 DevToolsManager* manager = DevToolsManager::GetInstance();
120 manager->RegisterDevToolsClientHostFor(agent_host_.get(), 120 manager->RegisterDevToolsClientHostFor(agent_host_.get(),
121 frontend_host_.get()); 121 frontend_host_.get());
122 } 122 }
123 123
124 void ShellDevToolsFrontend::DocumentOnLoadCompletedInMainFrame(int32 page_id) { 124 void ShellDevToolsFrontend::DocumentOnLoadCompletedInMainFrame() {
125 web_contents()->GetMainFrame()->ExecuteJavaScript( 125 web_contents()->GetMainFrame()->ExecuteJavaScript(
126 base::ASCIIToUTF16("InspectorFrontendAPI.setUseSoftMenu(true);")); 126 base::ASCIIToUTF16("InspectorFrontendAPI.setUseSoftMenu(true);"));
127 } 127 }
128 128
129 void ShellDevToolsFrontend::WebContentsDestroyed(WebContents* web_contents) { 129 void ShellDevToolsFrontend::WebContentsDestroyed(WebContents* web_contents) {
130 DevToolsManager::GetInstance()->ClientHostClosing(frontend_host_.get()); 130 DevToolsManager::GetInstance()->ClientHostClosing(frontend_host_.get());
131 delete this; 131 delete this;
132 } 132 }
133 133
134 void ShellDevToolsFrontend::InspectedContentsClosing() { 134 void ShellDevToolsFrontend::InspectedContentsClosing() {
135 frontend_shell_->Close(); 135 frontend_shell_->Close();
136 } 136 }
137 137
138 } // namespace content 138 } // namespace content
OLDNEW
« no previous file with comments | « content/shell/browser/shell_devtools_frontend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698