Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/containers/hash_tables.h" 8 #include "base/containers/hash_tables.h"
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/metrics/user_metrics_action.h" 10 #include "base/metrics/user_metrics_action.h"
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 void RenderFrameHostImpl::OnOpenURL( 352 void RenderFrameHostImpl::OnOpenURL(
353 const FrameHostMsg_OpenURL_Params& params) { 353 const FrameHostMsg_OpenURL_Params& params) {
354 GURL validated_url(params.url); 354 GURL validated_url(params.url);
355 GetProcess()->FilterURL(false, &validated_url); 355 GetProcess()->FilterURL(false, &validated_url);
356 356
357 frame_tree_node_->navigator()->RequestOpenURL( 357 frame_tree_node_->navigator()->RequestOpenURL(
358 this, validated_url, params.referrer, params.disposition, 358 this, validated_url, params.referrer, params.disposition,
359 params.should_replace_current_entry, params.user_gesture); 359 params.should_replace_current_entry, params.user_gesture);
360 } 360 }
361 361
362 void RenderFrameHostImpl::OnDocumentOnLoadCompleted( 362 void RenderFrameHostImpl::OnDocumentOnLoadCompleted() {
363 int32 page_id) {
364 // This message is only sent for top-level frames. TODO(avi): when frame tree 363 // This message is only sent for top-level frames. TODO(avi): when frame tree
365 // mirroring works correctly, add a check here to enforce it. 364 // mirroring works correctly, add a check here to enforce it.
366 delegate_->DocumentOnLoadCompleted(this, page_id); 365 delegate_->DocumentOnLoadCompleted(this);
367 } 366 }
368 367
369 void RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame( 368 void RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame(
370 int parent_routing_id, 369 int parent_routing_id,
371 const GURL& url) { 370 const GURL& url) {
372 frame_tree_node_->navigator()->DidStartProvisionalLoad( 371 frame_tree_node_->navigator()->DidStartProvisionalLoad(
373 this, parent_routing_id, url); 372 this, parent_routing_id, url);
374 } 373 }
375 374
376 void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError( 375 void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError(
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
856 cancel_notification_callbacks_.erase(notification_id); 855 cancel_notification_callbacks_.erase(notification_id);
857 } 856 }
858 857
859 void RenderFrameHostImpl::DesktopNotificationPermissionRequestDone( 858 void RenderFrameHostImpl::DesktopNotificationPermissionRequestDone(
860 int callback_context) { 859 int callback_context) {
861 Send(new DesktopNotificationMsg_PermissionRequestDone( 860 Send(new DesktopNotificationMsg_PermissionRequestDone(
862 routing_id_, callback_context)); 861 routing_id_, callback_context));
863 } 862 }
864 863
865 } // namespace content 864 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698