Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: apps/app_window.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « android_webview/browser/icon_helper.cc ('k') | apps/app_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef APPS_APP_WINDOW_H_ 5 #ifndef APPS_APP_WINDOW_H_
6 #define APPS_APP_WINDOW_H_ 6 #define APPS_APP_WINDOW_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/extensions/extension_icon_image.h" 10 #include "chrome/browser/extensions/extension_icon_image.h"
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 const content::NativeWebKeyboardEvent& event) 398 const content::NativeWebKeyboardEvent& event)
399 OVERRIDE; 399 OVERRIDE;
400 virtual void RequestToLockMouse(content::WebContents* web_contents, 400 virtual void RequestToLockMouse(content::WebContents* web_contents,
401 bool user_gesture, 401 bool user_gesture,
402 bool last_unlocked_by_target) OVERRIDE; 402 bool last_unlocked_by_target) OVERRIDE;
403 virtual bool PreHandleGestureEvent(content::WebContents* source, 403 virtual bool PreHandleGestureEvent(content::WebContents* source,
404 const blink::WebGestureEvent& event) 404 const blink::WebGestureEvent& event)
405 OVERRIDE; 405 OVERRIDE;
406 406
407 // content::WebContentsObserver implementation. 407 // content::WebContentsObserver implementation.
408 virtual void DidFirstVisuallyNonEmptyPaint(int32 page_id) OVERRIDE; 408 virtual void DidFirstVisuallyNonEmptyPaint() OVERRIDE;
409 409
410 // content::NotificationObserver implementation. 410 // content::NotificationObserver implementation.
411 virtual void Observe(int type, 411 virtual void Observe(int type,
412 const content::NotificationSource& source, 412 const content::NotificationSource& source,
413 const content::NotificationDetails& details) OVERRIDE; 413 const content::NotificationDetails& details) OVERRIDE;
414 414
415 // web_modal::WebContentsModalDialogManagerDelegate implementation. 415 // web_modal::WebContentsModalDialogManagerDelegate implementation.
416 virtual void SetWebContentsBlocked(content::WebContents* web_contents, 416 virtual void SetWebContentsBlocked(content::WebContents* web_contents,
417 bool blocked) OVERRIDE; 417 bool blocked) OVERRIDE;
418 virtual bool IsWebContentsVisible(content::WebContents* web_contents) 418 virtual bool IsWebContentsVisible(content::WebContents* web_contents)
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 // reinstated when the window exits fullscreen and moves away from the 527 // reinstated when the window exits fullscreen and moves away from the
528 // taskbar. 528 // taskbar.
529 bool cached_always_on_top_; 529 bool cached_always_on_top_;
530 530
531 DISALLOW_COPY_AND_ASSIGN(AppWindow); 531 DISALLOW_COPY_AND_ASSIGN(AppWindow);
532 }; 532 };
533 533
534 } // namespace apps 534 } // namespace apps
535 535
536 #endif // APPS_APP_WINDOW_H_ 536 #endif // APPS_APP_WINDOW_H_
OLDNEW
« no previous file with comments | « android_webview/browser/icon_helper.cc ('k') | apps/app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698