Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/favicon/favicon_handler.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 FaviconDriver* driver, 90 FaviconDriver* driver,
91 Type icon_type, 91 Type icon_type,
92 bool download_largest_icon); 92 bool download_largest_icon);
93 virtual ~FaviconHandler(); 93 virtual ~FaviconHandler();
94 94
95 // Initiates loading the favicon for the specified url. 95 // Initiates loading the favicon for the specified url.
96 void FetchFavicon(const GURL& url); 96 void FetchFavicon(const GURL& url);
97 97
98 // Message Handler. Must be public, because also called from 98 // Message Handler. Must be public, because also called from
99 // PrerenderContents. Collects the |image_urls| list. 99 // PrerenderContents. Collects the |image_urls| list.
100 void OnUpdateFaviconURL(int32 page_id, 100 void OnUpdateFaviconURL(const std::vector<content::FaviconURL>& candidates);
101 const std::vector<content::FaviconURL>& candidates);
102 101
103 // Processes the current image_irls_ entry, requesting the image from the 102 // Processes the current image_irls_ entry, requesting the image from the
104 // history / download service. 103 // history / download service.
105 void ProcessCurrentUrl(); 104 void ProcessCurrentUrl();
106 105
107 // Message handler for ImageHostMsg_DidDownloadImage. Called when the image 106 // Message handler for ImageHostMsg_DidDownloadImage. Called when the image
108 // at |image_url| has been downloaded. 107 // at |image_url| has been downloaded.
109 // |bitmaps| is a list of all the frames of the image at |image_url|. 108 // |bitmaps| is a list of all the frames of the image at |image_url|.
110 // |original_bitmap_sizes| are the sizes of |bitmaps| before they were resized 109 // |original_bitmap_sizes| are the sizes of |bitmaps| before they were resized
111 // to the maximum bitmap size passed to DownloadFavicon(). 110 // to the maximum bitmap size passed to DownloadFavicon().
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 // Best image we've seen so far. As images are downloaded from the page they 300 // Best image we've seen so far. As images are downloaded from the page they
302 // are stored here. When there is an exact match, or no more images are 301 // are stored here. When there is an exact match, or no more images are
303 // available the favicon service and the NavigationEntry are updated (assuming 302 // available the favicon service and the NavigationEntry are updated (assuming
304 // the image is for a favicon). 303 // the image is for a favicon).
305 FaviconCandidate best_favicon_candidate_; 304 FaviconCandidate best_favicon_candidate_;
306 305
307 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 306 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
308 }; 307 };
309 308
310 #endif // CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_ 309 #endif // CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/favicon_downloader_unittest.cc ('k') | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698