chrome/browser/devtools/devtools_ui_bindings.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index be64ac99e6b7b3f87c5ddb398b862a8b062462ab..afe5a5aaa7f671b09fb8959d566fbf5f7f5023ef 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -235,7 +235,7 @@ class DevToolsUIBindings::FrontendWebContentsObserver

// contents::WebContentsObserver:

virtual void AboutToNavigateRenderView(

content::RenderViewHost* render_view_host) OVERRIDE;

- virtual void DocumentOnLoadCompletedInMainFrame(int32 page_id) OVERRIDE;

+ virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;

DevToolsUIBindings* devtools_bindings_;

DISALLOW_COPY_AND_ASSIGN(FrontendWebContentsObserver);

@@ -257,7 +257,7 @@ void DevToolsUIBindings::FrontendWebContentsObserver::AboutToNavigateRenderView(

}

void DevToolsUIBindings::FrontendWebContentsObserver::

- DocumentOnLoadCompletedInMainFrame(int32 page_id) {

+ DocumentOnLoadCompletedInMainFrame() {

devtools_bindings_->DocumentOnLoadCompletedInMainFrame();

}

« no previous file with comments | « apps/app_window.cc ('k') | chrome/browser/extensions/favicon_downloader.h » ('j') | no next file with comments »