Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the constructors (other than default, copy and
assignment) of VisibleSelection as private and introducing new functions
createVisibleSelection[Deprecated] for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All call sites of the constructors
hidden by this patch are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373
Committed: https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755
Cr-Commit-Position: refs/heads/master@{#422011}

[Xiaocheng, 2016-09-29 10:40:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 10:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-29 10:45:27]

Description was changed from

==========
Introduce and switch to createVisibleSelectionDeprecated

BUG=
==========

to

==========
Make non-null VisibleSelection created only by
createVisibleSelection[Deprecated]

BUG=651373
==========

[commit-bot: I haz the power, 2016-09-29 11:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:04:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-09-29 13:03:49]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 13:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-29 14:10:51]

Description was changed from

==========
Make non-null VisibleSelection created only by
createVisibleSelection[Deprecated]

BUG=651373
==========

to

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the non-default constructors of VisibleSelection
as private and introducing new functions createVisibleSelection[Deprecated]
for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout by itself. All current call sites of the original non-
default constructors are switched to call it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will
ensure clean layout and switch to createVisibleSelection.

BUG=651373
==========

[Xiaocheng, 2016-09-29 14:10:52]

xiaochengh@chromium.org changed reviewers:
+ dmazzoni@chromium.org, tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-09-29 14:12:33]

Description was changed from

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the non-default constructors of VisibleSelection
as private and introducing new functions createVisibleSelection[Deprecated]
for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout by itself. All current call sites of the original non-
default constructors are switched to call it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will
ensure clean layout and switch to createVisibleSelection.

BUG=651373
==========

to

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the non-default constructors of VisibleSelection
as private and introducing new functions createVisibleSelection[Deprecated]
for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All current call sites of the original
non-default constructors are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373
==========

[Xiaocheng, 2016-09-29 14:18:25]

Description was changed from

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the non-default constructors of VisibleSelection
as private and introducing new functions createVisibleSelection[Deprecated]
for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All current call sites of the original
non-default constructors are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373
==========

to

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the constructors (other than default, copy and
assignment) of VisibleSelection as private and introducing new functions
createVisibleSelection[Deprecated] for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All call sites of the constructors
hidden by this patch are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373
==========

[Xiaocheng, 2016-09-29 14:18:40]

PTAL.

[commit-bot: I haz the power, 2016-09-29 14:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:34:36]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-09-29 15:03:40]

lgtm

[dglazkov, 2016-09-29 15:53:40]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2016-09-29 15:53:41]

lgtm

[yosin_UTC9, 2016-09-30 01:20:36]

lgtm

Thanks for non-mechanical big change!
(^_^)b

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:107: if
(extent.isNotNull())
Note: We will fix callers which pass base=null, extent=non-null.

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelection.h (right):

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelection.h:57: //
TODO(xiaochengh): Use enum class instead of boolean parameter.
Once Selection class introduced, we don't need to use enum class.

We would write as:
Selection::Builder builder;
builder.collapse(base).extend(extent)
  .setIsDirectional(true)
  .setAffinity(TextAffinity::Downstream);
VisibleSelection selection = createVisibleSelectionDeprecated(builder.build());

Until C++ introduce named parameter, builder patter is useful.

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/2374183004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1918:
frame->selection().setSelection(createVisibleSelection(anchorVisiblePosition,
focusVisiblePosition));
Since AXLayoutObject holds |m_layoutObject|, when |VisibleSelection| ctor causes
layout and blow up this AXLayoutObject.
So, this change declare |createVisibleSlection()| don't cause layout.
Nice!

[Xiaocheng, 2016-09-30 01:43:25]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-30 01:43:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-30 01:44:17]

Thanks for the review. Committing it...

[commit-bot: I haz the power, 2016-09-30 01:55:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-30 02:00:49]

Description was changed from

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the constructors (other than default, copy and
assignment) of VisibleSelection as private and introducing new functions
createVisibleSelection[Deprecated] for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All call sites of the constructors
hidden by this patch are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373
==========

to

==========
Make non-null VisibleSelections creatable only by
createVisibleSelection[Deprecated]

This patch is a preparation for enforcing the creation of VisibleSelections
in clean layout, by hiding the constructors (other than default, copy and
assignment) of VisibleSelection as private and introducing new functions
createVisibleSelection[Deprecated] for creating new VisibleSelections.

createVisibleSelectionDeprecated can be called with dirty layout, and performs
synchronous layout update by itself. All call sites of the constructors
hidden by this patch are switched to it, except for that in AXLayoutObject.

createVisibleSelection must be called with clean layout. The above-mentioned
call site in AXLayoutObject is switched to call createVisibleSelection since
it is known to have ensured clean layout.

In future patches, all call sites of createVisibleSelectionDeprecated will be
made to ensure clean layout and then switch to createVisibleSelection.

BUG=651373

Committed: https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755
Cr-Commit-Position: refs/heads/master@{#422011}
==========

[commit-bot: I haz the power, 2016-09-30 02:00:51]

Patchset 3 (id:??) landed as
https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755
Cr-Commit-Position: refs/heads/master@{#422011}