Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp b/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
index a8aec12420fbc1a9a04666f5db9cc1dbd7415be3..95207a85f93d44a7f9b4a70d1ac919dd9918351f 100644
--- a/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
@@ -19,7 +19,7 @@ TEST_F(SelectionAdjusterTest, adjustSelectionInFlatTree)
Node* const sample = document().getElementById("sample");
Node* const foo = sample->firstChild();
// Select "foo"
- VisibleSelection selection(Position(foo, 0), Position(foo, 3));
+ VisibleSelection selection = createVisibleSelectionDeprecated(Position(foo, 0), Position(foo, 3));
SelectionAdjuster::adjustSelectionInFlatTree(&selectionInFlatTree, selection);
EXPECT_EQ(PositionInFlatTree(foo, 0), selectionInFlatTree.start());
EXPECT_EQ(PositionInFlatTree(foo, 3), selectionInFlatTree.end());
@@ -33,7 +33,7 @@ TEST_F(SelectionAdjusterTest, adjustSelectionInDOMTree)
Node* const sample = document().getElementById("sample");
Node* const foo = sample->firstChild();
// Select "foo"
- VisibleSelectionInFlatTree selectionInFlatTree(
+ VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelectionDeprecated(
PositionInFlatTree(foo, 0),
PositionInFlatTree(foo, 3));
SelectionAdjuster::adjustSelectionInDOMTree(&selection, selectionInFlatTree);

Powered by Google App Engine
This is Rietveld 408576698