third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 75a511750603f778f02c9f6a4b1dff32a8d1591e..7a5800dc028cec42a5e5bfeb05c8cc23a57875ad 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -1561,9 +1561,9 @@ void ReplaceSelectionCommand::completeHTMLReplacement(const Position &lastPositi

m_endOfInsertedRange = end;

if (m_selectReplacement)

- setEndingSelection(VisibleSelection(start, end, SelDefaultAffinity, endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(start, end, SelDefaultAffinity, endingSelection().isDirectional()));

else

- setEndingSelection(VisibleSelection(end, SelDefaultAffinity, endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(end, SelDefaultAffinity, endingSelection().isDirectional()));

}

void ReplaceSelectionCommand::mergeTextNodesAroundPosition(Position& position, Position& positionOnlyToBeUpdated, EditingState* editingState)

@@ -1738,7 +1738,7 @@ bool ReplaceSelectionCommand::performTrivialReplace(const ReplacementFragment& f

m_startOfInsertedRange = start;

m_endOfInsertedRange = end;

- VisibleSelection selectionAfterReplace(m_selectReplacement ? start : end, end);

+ VisibleSelection selectionAfterReplace = createVisibleSelectionDeprecated(m_selectReplacement ? start : end, end);

setEndingSelection(selectionAfterReplace);