third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index e1e94fb875ac252d8a78f430efcaa3edda024005..5bf4aeaa20607bc1ef888e1de0835b693f552c5c 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -101,7 +101,7 @@ bool InsertTextCommand::performTrivialReplace(const String& text, bool selectIns

setEndingSelectionWithoutValidation(start, endPosition);

if (!selectInsertedText)

- setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

return true;

}

@@ -124,7 +124,7 @@ bool InsertTextCommand::performOverwrite(const String& text, bool selectInserted

Position endPosition = Position(textNode, start.offsetInContainerNode() + text.length());

setEndingSelectionWithoutValidation(start, endPosition);

if (!selectInsertedText)

- setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

return true;

}

@@ -245,7 +245,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

}

if (!m_selectInsertedText)

- setEndingSelection(VisibleSelection(endingSelection().end(), endingSelection().affinity(), endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(endingSelection().end(), endingSelection().affinity(), endingSelection().isDirectional()));

}

Position InsertTextCommand::insertTab(const Position& pos, EditingState* editingState)