Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 83 matching lines @@
     if (text.contains('\t') || text.contains(' ') || text.contains('\n'))
         return false;
 
     Position start = endingSelection().start();
     Position endPosition = replaceSelectedTextInNode(text);
     if (endPosition.isNull())
         return false;
 
     setEndingSelectionWithoutValidation(start, endPosition);
     if (!selectInsertedText)
-        setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));
 
     return true;
 }
 
 bool InsertTextCommand::performOverwrite(const String& text, bool selectInsertedText)
 {
     Position start = endingSelection().start();
     if (start.isNull() || !start.isOffsetInAnchor() || !start.computeContainerNode()->isTextNode())
         return false;
     Text* textNode = toText(start.computeContainerNode());
     if (!textNode)
         return false;
 
     unsigned count = std::min(text.length(), textNode->length() - start.offsetInContainerNode());
     if (!count)
         return false;
 
     replaceTextInNode(textNode, start.offsetInContainerNode(), count, text);
 
     Position endPosition = Position(textNode, start.offsetInContainerNode() + text.length());
     setEndingSelectionWithoutValidation(start, endPosition);
     if (!selectInsertedText)
-        setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));
 
     return true;
 }
 
 void InsertTextCommand::doApply(EditingState* editingState)
 {
     DCHECK_EQ(m_text.find('\n'), kNotFound);
 
     if (!endingSelection().isNonOrphanedCaretOrRange())
         return;
@@ skipping 100 matching lines @@
     if (EditingStyle* typingStyle = document().frame()->selection().typingStyle()) {
         typingStyle->prepareToApplyAt(endPosition, EditingStyle::PreserveWritingDirection);
         if (!typingStyle->isEmpty()) {
             applyStyle(typingStyle, editingState);
             if (editingState->isAborted())
                 return;
         }
     }
 
     if (!m_selectInsertedText)
-        setEndingSelection(VisibleSelection(endingSelection().end(), endingSelection().affinity(), endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(endingSelection().end(), endingSelection().affinity(), endingSelection().isDirectional()));
 }
 
 Position InsertTextCommand::insertTab(const Position& pos, EditingState* editingState)
 {
     Position insertPos = createVisiblePositionDeprecated(pos).deepEquivalent();
     if (insertPos.isNull())
         return pos;
 
     Node* node = insertPos.computeContainerNode();
     unsigned offset = node->isTextNode() ? insertPos.offsetInContainerNode() : 0;
@@ skipping 26 matching lines @@
         }
     }
     if (editingState->isAborted())
         return Position();
 
     // return the position following the new tab
     return Position::lastPositionInNode(spanElement);
 }
 
 } // namespace blink