Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/page/DragController.cpp

 /*
  * Copyright (C) 2007, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 415 matching lines @@
 
     if (doc && (m_didInitiateDrag || doc->isPluginDocument() || hasEditableStyle(*doc)))
         return DragOperationNone;
     return dragOperation(dragData);
 }
 
 static bool setSelectionToDragCaret(LocalFrame* frame, VisibleSelection& dragCaret, Range*& range, const IntPoint& point)
 {
     frame->selection().setSelection(dragCaret);
     if (frame->selection().isNone()) {
-        dragCaret = VisibleSelection(frame->positionForPoint(point));
+        dragCaret = createVisibleSelectionDeprecated(frame->positionForPoint(point));
         frame->selection().setSelection(dragCaret);
         range = createRange(dragCaret.toNormalizedEphemeralRange());
     }
     return !frame->selection().isNone() && frame->selection().isContentEditable();
 }
 
 DispatchEventResult DragController::dispatchTextInputEventFor(LocalFrame* innerFrame, DragData* dragData)
 {
     ASSERT(m_page->dragCaretController().hasCaret());
     String text = m_page->dragCaretController().isContentRichlyEditable() ? "" : dragData->asPlainText();
-    Element* target = innerFrame->editor().findEventTargetFrom(VisibleSelection(m_page->dragCaretController().caretPosition()));
+    Element* target = innerFrame->editor().findEventTargetFrom(createVisibleSelectionDeprecated(m_page->dragCaretController().caretPosition()));
     return target->dispatchEvent(TextEvent::createForDrop(innerFrame->domWindow(), text));
 }
 
 bool DragController::concludeEditDrag(DragData* dragData)
 {
     ASSERT(dragData);
 
     HTMLInputElement* fileInput = m_fileInputElementUnderMouse;
     if (m_fileInputElementUnderMouse) {
         m_fileInputElementUnderMouse->setCanReceiveDroppedFiles(false);
@@ skipping 21 matching lines @@
             return false;
 
         return fileInput->receiveDroppedFiles(dragData);
     }
 
     if (!m_page->dragController().canProcessDrag(dragData)) {
         m_page->dragCaretController().clear();
         return false;
     }
 
-    VisibleSelection dragCaret(m_page->dragCaretController().caretPosition());
+    VisibleSelection dragCaret = createVisibleSelectionDeprecated(m_page->dragCaretController().caretPosition());
     m_page->dragCaretController().clear();
     // |innerFrame| can be removed by event handler called by
     // |dispatchTextInputEventFor()|.
     if (!innerFrame->selection().isAvailable()) {
         // "editing/pasteboard/drop-text-events-sideeffect-crash.html" reaches
         // here.
         return false;
     }
     Range* range = createRange(dragCaret.toNormalizedEphemeralRange());
     Element* rootEditableElement = innerFrame->selection().rootEditableElement();
@@ skipping 215 matching lines @@
     return (cachedImage && !cachedImage->errorOccurred()) ?
         cachedImage->getImage() : nullptr;
 }
 
 static void prepareDataTransferForImageDrag(LocalFrame* source, DataTransfer* dataTransfer, Element* node, const KURL& linkURL, const KURL& imageURL, const String& label)
 {
     node->document().updateStyleAndLayoutTree();
     if (hasRichlyEditableStyle(*node)) {
         Range* range = source->document()->createRange();
         range->selectNode(node, ASSERT_NO_EXCEPTION);
-        source->selection().setSelection(VisibleSelection(EphemeralRange(range)));
+        source->selection().setSelection(createVisibleSelectionDeprecated(EphemeralRange(range)));
     }
     dataTransfer->declareAndWriteDragImage(node, !linkURL.isEmpty() ? linkURL : imageURL, label);
 }
 
 bool DragController::populateDragDataTransfer(LocalFrame* src, const DragState& state, const IntPoint& dragOrigin)
 {
     ASSERT(dragTypeIsValid(state.m_dragType));
     ASSERT(src);
     if (!src->view() || src->contentLayoutItem().isNull())
         return false;
@@ skipping 261 matching lines @@
 
 DEFINE_TRACE(DragController)
 {
     visitor->trace(m_page);
     visitor->trace(m_documentUnderMouse);
     visitor->trace(m_dragInitiator);
     visitor->trace(m_fileInputElementUnderMouse);
 }
 
 } // namespace blink