third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

index eb70b3574f76684adf611519373a42baf4f528fc..ef83fc4a3824162ea13878221e22e4ece05ed7ee 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

@@ -33,7 +33,7 @@ TEST_F(InsertListCommandTest, ShouldCleanlyRemoveSpuriousTextNode)

setBodyContent("\nd\n<ol>");

Text* emptyText = document().createTextNode("");

document().body()->insertBefore(emptyText, document().body()->firstChild());

- document().frame()->selection().setSelection(VisibleSelection(Position(document().body(), 0), Position(document().body(), 2)));

+ document().frame()->selection().setSelection(createVisibleSelectionDeprecated(Position(document().body(), 0), Position(document().body(), 2)));

InsertListCommand* command = InsertListCommand::create(document(), InsertListCommand::OrderedList);

// This should not DCHECK.