Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 55 matching lines @@
 
     // When a selection ends at the start of a paragraph, we rarely paint
     // the selection gap before that paragraph, because there often is no gap.
     // In a case like this, it's not obvious to the user that the selection
     // ends "inside" that paragraph, so it would be confusing if Indent/Outdent
     // operated on that paragraph.
     // FIXME: We paint the gap before some paragraphs that are indented with left
     // margin/padding, but not others.  We should make the gap painting more
     // consistent and then use a left margin/padding rule here.
     if (visibleEnd.deepEquivalent() != visibleStart.deepEquivalent() && isStartOfParagraphDeprecated(visibleEnd)) {
-        VisibleSelection newSelection(visibleStart, previousPositionOf(visibleEnd, CannotCrossEditingBoundary), endingSelection().isDirectional());
+        VisibleSelection newSelection = createVisibleSelectionDeprecated(visibleStart, previousPositionOf(visibleEnd, CannotCrossEditingBoundary), endingSelection().isDirectional());
         if (newSelection.isNone())
             return;
         setEndingSelection(newSelection);
     }
 
     VisibleSelection selection = selectionForParagraphIteration(endingSelection());
     VisiblePosition startOfSelection = selection.visibleStartDeprecated();
     VisiblePosition endOfSelection = selection.visibleEndDeprecated();
     DCHECK(!startOfSelection.isNull());
     DCHECK(!endOfSelection.isNull());
     ContainerNode* startScope = nullptr;
     int startIndex = indexForVisiblePosition(startOfSelection, startScope);
     ContainerNode* endScope = nullptr;
     int endIndex = indexForVisiblePosition(endOfSelection, endScope);
 
     formatSelection(startOfSelection, endOfSelection, editingState);
     if (editingState->isAborted())
         return;
 
     document().updateStyleAndLayoutIgnorePendingStylesheets();
 
     DCHECK_EQ(startScope, endScope);
     DCHECK_GE(startIndex, 0);
     DCHECK_LE(startIndex, endIndex);
     if (startScope == endScope && startIndex >= 0 && startIndex <= endIndex) {
         VisiblePosition start(visiblePositionForIndex(startIndex, startScope));
         VisiblePosition end(visiblePositionForIndex(endIndex, endScope));
         if (start.isNotNull() && end.isNotNull())
-            setEndingSelection(VisibleSelection(start, end, endingSelection().isDirectional()));
+            setEndingSelection(createVisibleSelectionDeprecated(start, end, endingSelection().isDirectional()));
     }
 }
 
 static bool isAtUnsplittableElement(const Position& pos)
 {
     Node* node = pos.anchorNode();
     return node == rootEditableElementOf(pos) || node == enclosingNodeOfType(pos, &isTableCell);
 }
 
 void ApplyBlockElementCommand::formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection, EditingState* editingState)
 {
     // Special case empty unsplittable elements because there's nothing to split
     // and there's nothing to move.
     Position start = mostForwardCaretPosition(startOfSelection.deepEquivalent());
     if (isAtUnsplittableElement(start)) {
         HTMLElement* blockquote = createBlockElement();
         insertNodeAt(blockquote, start, editingState);
         if (editingState->isAborted())
             return;
         HTMLBRElement* placeholder = HTMLBRElement::create(document());
         appendNode(placeholder, blockquote, editingState);
         if (editingState->isAborted())
             return;
-        setEndingSelection(VisibleSelection(Position::beforeNode(placeholder), TextAffinity::Downstream, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(Position::beforeNode(placeholder), TextAffinity::Downstream, endingSelection().isDirectional()));
         return;
     }
 
     HTMLElement* blockquoteForNextIndent = nullptr;
     VisiblePosition endOfCurrentParagraph = endOfParagraphDeprecated(startOfSelection);
     VisiblePosition endOfLastParagraph = endOfParagraphDeprecated(endOfSelection);
     VisiblePosition endAfterSelection = endOfParagraphDeprecated(nextPositionOf(endOfLastParagraph));
     m_endOfLastParagraph = endOfLastParagraph.deepEquivalent();
 
     bool atEnd = false;
@@ skipping 166 matching lines @@
     return element;
 }
 
 DEFINE_TRACE(ApplyBlockElementCommand)
 {
     visitor->trace(m_endOfLastParagraph);
     CompositeEditCommand::trace(visitor);
 }
 
 } // namespace blink