Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1221 matching lines @@
 
     // We upstream() the end and downstream() the start so that we don't include collapsed whitespace in the move.
     // When we paste a fragment, spaces after the end and before the start are treated as though they were rendered.
     Position start = mostForwardCaretPosition(startOfParagraphToMove.deepEquivalent());
     Position end = startOfParagraphToMove.deepEquivalent() == endOfParagraphToMove.deepEquivalent() ? start : mostBackwardCaretPosition(endOfParagraphToMove.deepEquivalent());
     if (comparePositions(start, end) > 0)
         end = start;
 
     cloneParagraphUnderNewElement(start, end, outerNode, blockElement, editingState);
 
-    setEndingSelection(VisibleSelection(start, end));
+    setEndingSelection(createVisibleSelectionDeprecated(start, end));
     deleteSelection(editingState, false, false, false);
     if (editingState->isAborted())
         return;
 
     // There are bugs in deletion when it removes a fully selected table/list.
     // It expands and removes the entire table/list, but will let content
     // before and after the table/list collapse onto one line.
 
     cleanupAfterDeletion(editingState);
     if (editingState->isAborted())
@@ skipping 81 matching lines @@
     EditingStyle* styleInEmptyParagraph = nullptr;
     if (startOfParagraphToMove.deepEquivalent() == endOfParagraphToMove.deepEquivalent() && shouldPreserveStyle == PreserveStyle) {
         styleInEmptyParagraph = EditingStyle::create(startOfParagraphToMove.deepEquivalent());
         styleInEmptyParagraph->mergeTypingStyle(&document());
         // The moved paragraph should assume the block style of the destination.
         styleInEmptyParagraph->removeBlockProperties();
     }
 
     // FIXME (5098931): We should add a new insert action "WebViewInsertActionMoved" and call shouldInsertFragment here.
 
-    setEndingSelection(VisibleSelection(start, end));
+    setEndingSelection(createVisibleSelectionDeprecated(start, end));
     document().frame()->spellChecker().clearMisspellingsAndBadGrammarForMovingParagraphs(endingSelection());
     deleteSelection(editingState, false, false, false);
     if (editingState->isAborted())
         return;
 
     DCHECK(destination.deepEquivalent().isConnected()) << destination;
     cleanupAfterDeletion(editingState, destination);
     if (editingState->isAborted())
         return;
     DCHECK(destination.deepEquivalent().isConnected()) << destination;
@@ skipping 11 matching lines @@
         // FIXME: Trim text between beforeParagraph and afterParagraph if they aren't equal.
         insertNodeAt(HTMLBRElement::create(document()), beforeParagraph.deepEquivalent(), editingState);
         if (editingState->isAborted())
             return;
         // Need an updateLayout here in case inserting the br has split a text node.
         document().updateStyleAndLayoutIgnorePendingStylesheets();
     }
 
     destinationIndex = TextIterator::rangeLength(Position::firstPositionInNode(document().documentElement()), destination.toParentAnchoredPosition(), true);
 
-    VisibleSelection destinationSelection(destination, originalIsDirectional);
+    VisibleSelection destinationSelection = createVisibleSelectionDeprecated(destination, originalIsDirectional);
     if (endingSelection().isNone()) {
         // We abort executing command since |destination| becomes invisible.
         editingState->abort();
         return;
     }
     setEndingSelection(destinationSelection);
     ReplaceSelectionCommand::CommandOptions options = ReplaceSelectionCommand::SelectReplacement | ReplaceSelectionCommand::MovingParagraph;
     if (shouldPreserveStyle == DoNotPreserveStyle)
         options |= ReplaceSelectionCommand::MatchStyle;
     applyCommandToComposite(ReplaceSelectionCommand::create(document(), fragment, options), editingState);
@@ skipping 23 matching lines @@
     // instead of nbsps for some spaces that were rendered (11475), which causes
     // spaces to be collapsed during the move operation. This results in a call
     // to rangeFromLocationAndLength with a location past the end of the
     // document (which will return null).
     EphemeralRange startRange = PlainTextRange(destinationIndex + startIndex).createRangeForSelection(*documentElement);
     if (startRange.isNull())
         return;
     EphemeralRange endRange = PlainTextRange(destinationIndex + endIndex).createRangeForSelection(*documentElement);
     if (endRange.isNull())
         return;
-    setEndingSelection(VisibleSelection(startRange.startPosition(), endRange.startPosition(), TextAffinity::Downstream, originalIsDirectional));
+    setEndingSelection(createVisibleSelectionDeprecated(startRange.startPosition(), endRange.startPosition(), TextAffinity::Downstream, originalIsDirectional));
 }
 
 // FIXME: Send an appropriate shouldDeleteRange call.
 bool CompositeEditCommand::breakOutOfEmptyListItem(EditingState* editingState)
 {
     Node* emptyListItem = enclosingEmptyListItem(endingSelection().visibleStartDeprecated());
     if (!emptyListItem)
         return false;
 
     EditingStyle* style = EditingStyle::create(endingSelection().start());
@@ skipping 52 matching lines @@
         if (editingState->isAborted())
             return false;
         removeNode(isListItem(previousListNode) || isHTMLListElement(previousListNode) ? emptyListItem : listNode, editingState);
         if (editingState->isAborted())
             return false;
     }
 
     appendBlockPlaceholder(newBlock, editingState);
     if (editingState->isAborted())
         return false;
-    setEndingSelection(VisibleSelection(Position::firstPositionInNode(newBlock), TextAffinity::Downstream, endingSelection().isDirectional()));
+    setEndingSelection(createVisibleSelectionDeprecated(Position::firstPositionInNode(newBlock), TextAffinity::Downstream, endingSelection().isDirectional()));
 
     style->prepareToApplyAt(endingSelection().start());
     if (!style->isEmpty()) {
         applyStyle(style, editingState);
         if (editingState->isAborted())
             return false;
     }
 
     return true;
 }
@@ skipping 25 matching lines @@
     if (editingState->isAborted())
         return false;
     VisiblePosition atBR = VisiblePosition::beforeNode(br);
     // If the br we inserted collapsed, for example foo<br><blockquote>...</blockquote>, insert
     // a second one.
     if (!isStartOfParagraphDeprecated(atBR)) {
         insertNodeBefore(HTMLBRElement::create(document()), br, editingState);
         if (editingState->isAborted())
             return false;
     }
-    setEndingSelection(VisibleSelection(atBR, endingSelection().isDirectional()));
+    setEndingSelection(createVisibleSelectionDeprecated(atBR, endingSelection().isDirectional()));
 
     // If this is an empty paragraph there must be a line break here.
     if (!lineBreakExistsAtVisiblePosition(caret))
         return false;
 
     Position caretPos(mostForwardCaretPosition(caret.deepEquivalent()));
     // A line break is either a br or a preserved newline.
     DCHECK(isHTMLBRElement(caretPos.anchorNode()) || (caretPos.anchorNode()->isTextNode() && caretPos.anchorNode()->layoutObject()->style()->preserveNewline())) << caretPos;
 
     if (isHTMLBRElement(*caretPos.anchorNode())) {
@@ skipping 110 matching lines @@
 }
 
 DEFINE_TRACE(CompositeEditCommand)
 {
     visitor->trace(m_commands);
     visitor->trace(m_composition);
     EditCommand::trace(visitor);
 }
 
 } // namespace blink