Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 148 matching lines @@
 }
 
 const VisibleSelectionInFlatTree& FrameSelection::selectionInFlatTree() const
 {
     return visibleSelection<EditingInFlatTreeStrategy>();
 }
 
 void FrameSelection::moveTo(const VisiblePosition &pos, EUserTriggered userTriggered, CursorAlignOnScroll align)
 {
     SetSelectionOptions options = CloseTyping | ClearTypingStyle | userTriggered;
-    setSelection(VisibleSelection(pos, pos, selection().isDirectional()), options, align);
+    setSelection(createVisibleSelectionDeprecated(pos, pos, selection().isDirectional()), options, align);
 }
 
 void FrameSelection::moveTo(const Position &pos, TextAffinity affinity)
 {
     SetSelectionOptions options = CloseTyping | ClearTypingStyle;
-    setSelection(VisibleSelection(pos, affinity, selection().isDirectional()), options);
+    setSelection(createVisibleSelectionDeprecated(pos, affinity, selection().isDirectional()), options);
 }
 
 // TODO(xiaochengh): We should not use reference to return value.
 template <typename Strategy>
 static void adjustEndpointsAtBidiBoundary(VisiblePositionTemplate<Strategy>& visibleBase, VisiblePositionTemplate<Strategy>& visibleExtent)
 {
     DCHECK(visibleBase.isValid());
     DCHECK(visibleExtent.isValid());
 
     RenderedPosition base(visibleBase);
@@ skipping 630 matching lines @@
     // This method's purpose is it to make it easier to select iframes (in order to delete them).  Don't do anything if the iframe isn't deletable.
     if (!blink::hasEditableStyle(*ownerElementParent))
         return;
 
     // Create compute positions before and after the element.
     unsigned ownerElementNodeIndex = ownerElement->nodeIndex();
     VisiblePosition beforeOwnerElement = createVisiblePosition(Position(ownerElementParent, ownerElementNodeIndex));
     VisiblePosition afterOwnerElement = createVisiblePosition(Position(ownerElementParent, ownerElementNodeIndex + 1), VP_UPSTREAM_IF_POSSIBLE);
 
     // Focus on the parent frame, and then select from before this element to after.
-    VisibleSelection newSelection(beforeOwnerElement, afterOwnerElement);
+    VisibleSelection newSelection = createVisibleSelectionDeprecated(beforeOwnerElement, afterOwnerElement);
     page->focusController().setFocusedFrame(parent);
     // setFocusedFrame can dispatch synchronous focus/blur events.  The document
     // tree might be modified.
     if (newSelection.isNonOrphanedCaretOrRange())
         toLocalFrame(parent)->selection().setSelection(newSelection);
 }
 
 // Returns a shadow tree node for legacy shadow trees, a child of the
 // ShadowRoot node for new shadow trees, or 0 for non-shadow trees.
 static Node* nonBoundaryShadowTreeRootNode(const Position& position)
@@ skipping 56 matching lines @@
 
 bool FrameSelection::setSelectedRange(const EphemeralRange& range, TextAffinity affinity, SelectionDirectionalMode directional, SetSelectionOptions options)
 {
     if (range.isNull())
         return false;
     m_selectionEditor->resetLogicalRange();
     // Since |FrameSeleciton::setSelection()| dispatches events and DOM tree
     // can be modified by event handlers, we should create |Range| object before
     // calling it.
     Range* logicalRange = createRange(range);
-    VisibleSelection newSelection(range.startPosition(), range.endPosition(), affinity, directional == SelectionDirectionalMode::Directional);
+    VisibleSelection newSelection = createVisibleSelectionDeprecated(range.startPosition(), range.endPosition(), affinity, directional == SelectionDirectionalMode::Directional);
     setSelection(newSelection, options);
     m_selectionEditor->setLogicalRange(logicalRange);
     return true;
 }
 
 Range* FrameSelection::firstRange() const
 {
     return m_selectionEditor->firstRange();
 }
 
@@ skipping 293 matching lines @@
 
     Document* document = m_frame->document();
     bool caretBrowsing = m_frame->settings() && m_frame->settings()->caretBrowsingEnabled();
     if (!isNone() || !(blink::hasEditableStyle(*document) || caretBrowsing))
         return;
 
     Element* documentElement = document->documentElement();
     if (!documentElement)
         return;
     if (HTMLBodyElement* body = Traversal<HTMLBodyElement>::firstChild(*documentElement))
-        setSelection(VisibleSelection(firstPositionInOrBeforeNode(body), TextAffinity::Downstream));
+        setSelection(createVisibleSelectionDeprecated(firstPositionInOrBeforeNode(body), TextAffinity::Downstream));
 }
 
 // TODO(yoichio): We should have LocalFrame having FrameCaret,
 // Editor and PendingSelection using FrameCaret directly
 // and get rid of this.
 bool FrameSelection::shouldShowBlockCursor() const
 {
     return m_frameCaret->shouldShowBlockCursor();
 }
 
@@ skipping 59 matching lines @@
 }
 
 bool FrameSelection::selectWordAroundPosition(const VisiblePosition& position)
 {
     static const EWordSide wordSideList[2] = { RightWordIfOnBoundary, LeftWordIfOnBoundary };
     for (EWordSide wordSide : wordSideList) {
         VisiblePosition start = startOfWord(position, wordSide);
         VisiblePosition end = endOfWord(position, wordSide);
         String text = plainText(EphemeralRange(start.deepEquivalent(), end.deepEquivalent()));
         if (!text.isEmpty() && !isSeparator(text.characterStartingAt(0))) {
-            setSelection(VisibleSelection(start, end), WordGranularity);
+            setSelection(createVisibleSelectionDeprecated(start, end), WordGranularity);
             return true;
         }
     }
 
     return false;
 }
 
 GranularityStrategy* FrameSelection::granularityStrategy()
 {
     // We do lazy initalization for m_granularityStrategy, because if we
@@ skipping 22 matching lines @@
     VisibleSelection newSelection = granularityStrategy()->updateExtent(contentsPoint, m_frame);
     setSelection(
         newSelection,
         FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotClearStrategy | UserTriggered,
         CursorAlignOnScroll::IfNeeded,
         CharacterGranularity);
 }
 
 void FrameSelection::moveRangeSelection(const VisiblePosition& basePosition, const VisiblePosition& extentPosition, TextGranularity granularity)
 {
-    VisibleSelection newSelection(basePosition, extentPosition);
+    VisibleSelection newSelection = createVisibleSelectionDeprecated(basePosition, extentPosition);
     newSelection.expandUsingGranularity(granularity);
 
     if (newSelection.isNone())
         return;
 
     setSelection(newSelection, granularity);
 }
 
 void FrameSelection::updateIfNeeded()
 {
@@ skipping 46 matching lines @@
 
 void showTree(const blink::FrameSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
     else
         LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif