Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
index 99b1368da230cbb207683616488f9d2ddde2ecfb..311d6cad9ceb12f6f9af55bc9475d3d2a27b4c14 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
@@ -284,7 +284,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
if (editingState->isAborted())
return;
- setEndingSelection(VisibleSelection(Position::firstPositionInNode(parent), TextAffinity::Downstream, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(Position::firstPositionInNode(parent), TextAffinity::Downstream, endingSelection().isDirectional()));
return;
}
@@ -344,7 +344,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
return;
// In this case, we need to set the new ending selection.
- setEndingSelection(VisibleSelection(insertionPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(insertionPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
return;
}
@@ -364,7 +364,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
// If the insertion point is a break element, there is nothing else
// we need to do.
if (visiblePos.deepEquivalent().anchorNode()->layoutObject()->isBR()) {
- setEndingSelection(VisibleSelection(insertionPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(insertionPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
return;
}
}
@@ -480,7 +480,7 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState)
}
}
- setEndingSelection(VisibleSelection(Position::firstPositionInNode(blockToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(Position::firstPositionInNode(blockToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
applyStyleAfterInsertion(startBlock, editingState);
}

Powered by Google App Engine
This is Rietveld 408576698