Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

 /*
  * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 102 matching lines @@
             } else {
                 extraNode = nodeToInsert->cloneNode(false);
                 insertNodeAfter(extraNode, nodeToInsert, editingState);
             }
             if (editingState->isAborted())
                 return;
             nodeToInsert = extraNode;
         }
 
         VisiblePosition endingPosition = VisiblePosition::beforeNode(nodeToInsert);
-        setEndingSelection(VisibleSelection(endingPosition, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(endingPosition, endingSelection().isDirectional()));
     } else if (pos.computeEditingOffset() <= caretMinOffset(pos.anchorNode())) {
         insertNodeAt(nodeToInsert, pos, editingState);
         if (editingState->isAborted())
             return;
 
         // Insert an extra br or '\n' if the just inserted one collapsed.
         if (!isStartOfParagraphDeprecated(VisiblePosition::beforeNode(nodeToInsert))) {
             insertNodeBefore(nodeToInsert->cloneNode(false), nodeToInsert, editingState);
             if (editingState->isAborted())
                 return;
         }
 
-        setEndingSelection(VisibleSelection(Position::inParentAfterNode(*nodeToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(Position::inParentAfterNode(*nodeToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
     // If we're inserting after all of the rendered text in a text node, or into a non-text node,
     // a simple insertion is sufficient.
     } else if (!pos.anchorNode()->isTextNode() || pos.computeOffsetInContainerNode() >= caretMaxOffset(pos.anchorNode())) {
         insertNodeAt(nodeToInsert, pos, editingState);
         if (editingState->isAborted())
             return;
-        setEndingSelection(VisibleSelection(Position::inParentAfterNode(*nodeToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(Position::inParentAfterNode(*nodeToInsert), TextAffinity::Downstream, endingSelection().isDirectional()));
     } else if (pos.anchorNode()->isTextNode()) {
         // Split a text node
         Text* textNode = toText(pos.anchorNode());
         splitTextNode(textNode, pos.computeOffsetInContainerNode());
         insertNodeBefore(nodeToInsert, textNode, editingState);
         if (editingState->isAborted())
             return;
         Position endingPosition = Position::firstPositionInNode(textNode);
 
         // Handle whitespace that occurs after the split
@@ skipping 10 matching lines @@
                 insertTextIntoNode(textNode, 0, nonBreakingSpaceString());
             } else {
                 Text* nbspNode = document().createTextNode(nonBreakingSpaceString());
                 insertNodeAt(nbspNode, positionBeforeTextNode, editingState);
                 if (editingState->isAborted())
                     return;
                 endingPosition = Position::firstPositionInNode(nbspNode);
             }
         }
 
-        setEndingSelection(VisibleSelection(endingPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(endingPosition, TextAffinity::Downstream, endingSelection().isDirectional()));
     }
 
     // Handle the case where there is a typing style.
 
     EditingStyle* typingStyle = document().frame()->selection().typingStyle();
 
     if (typingStyle && !typingStyle->isEmpty()) {
         // Apply the typing style to the inserted line break, so that if the selection
         // leaves and then comes back, new input will have the right style.
         // FIXME: We shouldn't always apply the typing style to the line break here,
         // see <rdar://problem/5794462>.
         applyStyle(typingStyle, firstPositionInOrBeforeNode(nodeToInsert), lastPositionInOrAfterNode(nodeToInsert), editingState);
         if (editingState->isAborted())
             return;
         // Even though this applyStyle operates on a Range, it still sets an endingSelection().
         // It tries to set a VisibleSelection around the content it operated on. So, that VisibleSelection
         // will either (a) select the line break we inserted, or it will (b) be a caret just
         // before the line break (if the line break is at the end of a block it isn't selectable).
         // So, this next call sets the endingSelection() to a caret just after the line break
         // that we inserted, or just before it if it's at the end of a block.
         setEndingSelection(endingSelection().visibleEndDeprecated());
     }
 
     rebalanceWhitespace();
 }
 
 } // namespace blink