Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
index 120f00edb91517313206fc29f7f3060a85c5169a..5530a14c3899d4512a129440cc95f9b9c820ce50 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -1239,7 +1239,7 @@ void CompositeEditCommand::moveParagraphWithClones(const VisiblePosition& startO
cloneParagraphUnderNewElement(start, end, outerNode, blockElement, editingState);
- setEndingSelection(VisibleSelection(start, end));
+ setEndingSelection(createVisibleSelectionDeprecated(start, end));
deleteSelection(editingState, false, false, false);
if (editingState->isAborted())
return;
@@ -1341,7 +1341,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap
// FIXME (5098931): We should add a new insert action "WebViewInsertActionMoved" and call shouldInsertFragment here.
- setEndingSelection(VisibleSelection(start, end));
+ setEndingSelection(createVisibleSelectionDeprecated(start, end));
document().frame()->spellChecker().clearMisspellingsAndBadGrammarForMovingParagraphs(endingSelection());
deleteSelection(editingState, false, false, false);
if (editingState->isAborted())
@@ -1373,7 +1373,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap
destinationIndex = TextIterator::rangeLength(Position::firstPositionInNode(document().documentElement()), destination.toParentAnchoredPosition(), true);
- VisibleSelection destinationSelection(destination, originalIsDirectional);
+ VisibleSelection destinationSelection = createVisibleSelectionDeprecated(destination, originalIsDirectional);
if (endingSelection().isNone()) {
// We abort executing command since |destination| becomes invisible.
editingState->abort();
@@ -1417,7 +1417,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap
EphemeralRange endRange = PlainTextRange(destinationIndex + endIndex).createRangeForSelection(*documentElement);
if (endRange.isNull())
return;
- setEndingSelection(VisibleSelection(startRange.startPosition(), endRange.startPosition(), TextAffinity::Downstream, originalIsDirectional));
+ setEndingSelection(createVisibleSelectionDeprecated(startRange.startPosition(), endRange.startPosition(), TextAffinity::Downstream, originalIsDirectional));
}
// FIXME: Send an appropriate shouldDeleteRange call.
@@ -1490,7 +1490,7 @@ bool CompositeEditCommand::breakOutOfEmptyListItem(EditingState* editingState)
appendBlockPlaceholder(newBlock, editingState);
if (editingState->isAborted())
return false;
- setEndingSelection(VisibleSelection(Position::firstPositionInNode(newBlock), TextAffinity::Downstream, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(Position::firstPositionInNode(newBlock), TextAffinity::Downstream, endingSelection().isDirectional()));
style->prepareToApplyAt(endingSelection().start());
if (!style->isEmpty()) {
@@ -1536,7 +1536,7 @@ bool CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph(EditingState*
if (editingState->isAborted())
return false;
}
- setEndingSelection(VisibleSelection(atBR, endingSelection().isDirectional()));
+ setEndingSelection(createVisibleSelectionDeprecated(atBR, endingSelection().isDirectional()));
// If this is an empty paragraph there must be a line break here.
if (!lineBreakExistsAtVisiblePosition(caret))

Powered by Google App Engine
This is Rietveld 408576698