Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 142 matching lines @@
             end = e;
         }
     }
 }
 
 void DeleteSelectionCommand::setStartingSelectionOnSmartDelete(const Position& start, const Position& end)
 {
     bool isBaseFirst = startingSelection().isBaseFirst();
     VisiblePosition newBase = createVisiblePositionDeprecated(isBaseFirst ? start : end);
     VisiblePosition newExtent = createVisiblePositionDeprecated(isBaseFirst ? end : start);
-    setStartingSelection(VisibleSelection(newBase, newExtent, startingSelection().isDirectional()));
+    setStartingSelection(createVisibleSelectionDeprecated(newBase, newExtent, startingSelection().isDirectional()));
 }
 
 void DeleteSelectionCommand::initializePositionData(EditingState* editingState)
 {
     Position start, end;
     initializeStartEnd(start, end);
     DCHECK(start.isNotNull());
     DCHECK(end.isNotNull());
     if (!isEditablePosition(start)) {
         editingState->abort();
@@ skipping 701 matching lines @@
 
     saveTypingStyleState();
 
     // deleting just a BR is handled specially, at least because we do not
     // want to replace it with a placeholder BR!
     bool brResult = handleSpecialCaseBRDelete(editingState);
     if (editingState->isAborted())
         return;
     if (brResult) {
         calculateTypingStyleAfterDelete();
-        setEndingSelection(VisibleSelection(m_endingPosition, affinity, endingSelection().isDirectional()));
+        setEndingSelection(createVisibleSelectionDeprecated(m_endingPosition, affinity, endingSelection().isDirectional()));
         clearTransientState();
         rebalanceWhitespace();
         return;
     }
 
     handleGeneralDelete(editingState);
     if (editingState->isAborted())
         return;
 
     fixupWhitespace();
@@ skipping 27 matching lines @@
             insertNodeAt(placeholder, m_endingPosition, editingState);
             if (editingState->isAborted())
                 return;
         }
     }
 
     rebalanceWhitespaceAt(m_endingPosition);
 
     calculateTypingStyleAfterDelete();
 
-    setEndingSelection(VisibleSelection(m_endingPosition, affinity, endingSelection().isDirectional()));
+    setEndingSelection(createVisibleSelectionDeprecated(m_endingPosition, affinity, endingSelection().isDirectional()));
     clearTransientState();
 }
 
 InputEvent::InputType DeleteSelectionCommand::inputType() const
 {
     // |DeleteSelectionCommand| could be used with Cut, Menu Bar deletion and |TypingCommand|.
     // 1. Cut and Menu Bar deletion should rely on correct |m_inputType|.
     // 2. |TypingCommand| will supply the |inputType()|, so |m_inputType| could default to |InputType::None|.
     return m_inputType;
 }
@@ skipping 22 matching lines @@
     visitor->trace(m_deleteIntoBlockquoteStyle);
     visitor->trace(m_startRoot);
     visitor->trace(m_endRoot);
     visitor->trace(m_startTableRow);
     visitor->trace(m_endTableRow);
     visitor->trace(m_temporaryPlaceholder);
     CompositeEditCommand::trace(visitor);
 }
 
 } // namespace blink