Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 if (editingState->isAborted()) 49 if (editingState->isAborted())
50 return; 50 return;
51 } else { 51 } else {
52 insertNodeAt(anchorElement, endingSelection().start(), editingState); 52 insertNodeAt(anchorElement, endingSelection().start(), editingState);
53 if (editingState->isAborted()) 53 if (editingState->isAborted())
54 return; 54 return;
55 Text* textNode = Text::create(document(), m_url); 55 Text* textNode = Text::create(document(), m_url);
56 appendNode(textNode, anchorElement, editingState); 56 appendNode(textNode, anchorElement, editingState);
57 if (editingState->isAborted()) 57 if (editingState->isAborted())
58 return; 58 return;
59 setEndingSelection(VisibleSelection(Position::inParentBeforeNode(*anchor Element), Position::inParentAfterNode(*anchorElement), TextAffinity::Downstream, endingSelection().isDirectional())); 59 setEndingSelection(createVisibleSelectionDeprecated(Position::inParentBe foreNode(*anchorElement), Position::inParentAfterNode(*anchorElement), TextAffin ity::Downstream, endingSelection().isDirectional()));
60 } 60 }
61 } 61 }
62 62
63 InputEvent::InputType CreateLinkCommand::inputType() const 63 InputEvent::InputType CreateLinkCommand::inputType() const
64 { 64 {
65 return InputEvent::InputType::CreateLink; 65 return InputEvent::InputType::CreateLink;
66 } 66 }
67 67
68 } // namespace blink 68 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698