third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

index 8c9d77d5662425ce282aecdb374d835077039095..a299743b9955188610e2f568aeb6dd63292a24c1 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

@@ -33,7 +33,7 @@ TEST_F(ReplaceSelectionCommandTest, pastingEmptySpan)

LocalFrame* frame = document().frame();

frame->selection().setSelection(

- VisibleSelection(Position(document().body(), 0)));

+ createVisibleSelectionDeprecated(Position(document().body(), 0)));

DocumentFragment* fragment = document().createDocumentFragment();

fragment->appendChild(document().createElement("span", ASSERT_NO_EXCEPTION));

@@ -58,7 +58,7 @@ TEST_F(ReplaceSelectionCommandTest, styleTagsInPastedHeadIncludedInContent)

{

document().setDesignMode("on");

dummyPageHolder().frame().selection().setSelection(

- VisibleSelection(Position(document().body(), 0)));

+ createVisibleSelectionDeprecated(Position(document().body(), 0)));

DocumentFragment* fragment = document().createDocumentFragment();

fragment->parseHTML(