Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 2fe90bb6b3b9d7e53f4091b9e7ca35d99aeef42a..a1853e5f6ba5d434e0d83ec330bc6eb61118e0f7 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1673,7 +1673,7 @@ void WebLocalFrameImpl::setFindEndstateFocusAndSelection()
if (element.isFocusable()) {
// Found a focusable parent node. Set the active match as the
// selection and focus to the focusable node.
- frame()->selection().setSelection(VisibleSelection(activeMatchRange));
+ frame()->selection().setSelection(createVisibleSelectionDeprecated(activeMatchRange));
frame()->document()->setFocusedElement(&element, FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone, nullptr));
return;
}
@@ -1698,7 +1698,7 @@ void WebLocalFrameImpl::setFindEndstateFocusAndSelection()
// you'll have the last thing you found highlighted) and make sure that
// we have nothing focused (otherwise you might have text selected but
// a link focused, which is weird).
- frame()->selection().setSelection(VisibleSelection(activeMatchRange));
+ frame()->selection().setSelection(createVisibleSelectionDeprecated(activeMatchRange));
frame()->document()->clearFocusedElement();
// Finally clear the active match, for two reasons:

Powered by Google App Engine
This is Rietveld 408576698