third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index ff59f692da5e64999f8a10ff005688fa94c4e27b..d4d06c595bcdf07856ac7eb03f2da0c32976ebe5 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -160,7 +160,7 @@ void DeleteSelectionCommand::setStartingSelectionOnSmartDelete(const Position& s

bool isBaseFirst = startingSelection().isBaseFirst();

VisiblePosition newBase = createVisiblePositionDeprecated(isBaseFirst ? start : end);

VisiblePosition newExtent = createVisiblePositionDeprecated(isBaseFirst ? end : start);

- setStartingSelection(VisibleSelection(newBase, newExtent, startingSelection().isDirectional()));

+ setStartingSelection(createVisibleSelectionDeprecated(newBase, newExtent, startingSelection().isDirectional()));

}

void DeleteSelectionCommand::initializePositionData(EditingState* editingState)

@@ -882,7 +882,7 @@ void DeleteSelectionCommand::doApply(EditingState* editingState)

return;

if (brResult) {

calculateTypingStyleAfterDelete();

- setEndingSelection(VisibleSelection(m_endingPosition, affinity, endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(m_endingPosition, affinity, endingSelection().isDirectional()));

clearTransientState();

rebalanceWhitespace();

return;

@@ -930,7 +930,7 @@ void DeleteSelectionCommand::doApply(EditingState* editingState)

calculateTypingStyleAfterDelete();

- setEndingSelection(VisibleSelection(m_endingPosition, affinity, endingSelection().isDirectional()));

+ setEndingSelection(createVisibleSelectionDeprecated(m_endingPosition, affinity, endingSelection().isDirectional()));

clearTransientState();

}