third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)

Patch Set: Fix mac compile error Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index b5725222dbead44d33c0ed23f6436235849270b0..a434fc1f3b84efccbafbaa46368ab293b1f892ad 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1915,7 +1915,7 @@ void AXLayoutObject::setSelection(const AXRange& selection)

if (anchorVisiblePosition.isNull() || focusVisiblePosition.isNull())

return;

- frame->selection().setSelection(VisibleSelection(anchorVisiblePosition, focusVisiblePosition));

+ frame->selection().setSelection(createVisibleSelection(anchorVisiblePosition, focusVisiblePosition));

yosin_UTC9 2016/09/30 01:20:35 Since AXLayoutObject holds |m_layoutObject|, when

}

bool AXLayoutObject::isValidSelectionBound(const AXObject* boundObject) const