Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionModifier.cpp

Issue 2374183004: Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] (Closed)
Patch Set: Fix mac compile error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionModifier.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
index d40e8c706628e731ce1b21819f64f9a52a19b06e..c279ced550af228abcdd673345e6d96ecceba55c 100644
--- a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
@@ -587,7 +587,7 @@ bool SelectionModifier::modify(EAlteration alter, SelectionDirection direction,
switch (alter) {
case FrameSelection::AlterationMove:
- m_selection = VisibleSelection(position, m_selection.isDirectional());
+ m_selection = createVisibleSelectionDeprecated(position, m_selection.isDirectional());
break;
case FrameSelection::AlterationExtend:
@@ -697,7 +697,7 @@ bool SelectionModifier::modifyWithPageGranularity(EAlteration alter, unsigned ve
switch (alter) {
case FrameSelection::AlterationMove:
- m_selection = VisibleSelection(result, m_selection.isDirectional());
+ m_selection = createVisibleSelectionDeprecated(result, m_selection.isDirectional());
break;
case FrameSelection::AlterationExtend:
m_selection.setExtent(result);

Powered by Google App Engine
This is Rietveld 408576698