Change logging statements to not use the "%" operator.

Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2, \3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2, \3)/

BUG=598897
Committed: https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92
Cr-Commit-Position: refs/heads/master@{#408745}

[qyearsley, 2016-07-26 23:21:16]

Description was changed from

==========
Changing logging statements to not use the "%" operator.

This slightly improves readability because it decreases
the number of parantheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

BUG=598897
==========

to

==========
Changing logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parantheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

BUG=598897
==========

[qyearsley, 2016-07-26 23:21:16]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-07-27 00:13:56]

Description was changed from

==========
Changing logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parantheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

BUG=598897
==========

to

==========
Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

BUG=598897
==========

[qyearsley, 2016-07-27 00:14:03]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 01:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 01:27:02]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-27 16:58:42]

Description was changed from

==========
Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

BUG=598897
==========

to

==========
Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.


Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2,
\3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2,
\3)/

BUG=598897
==========

[qyearsley, 2016-07-29 16:17:49]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2016-07-29 18:35:44]

lgtm

[qyearsley, 2016-07-29 18:42:05]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:42:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:09:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 21:11:20]

Description was changed from

==========
Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.


Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2,
\3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2,
\3)/

BUG=598897
==========

to

==========
Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2,
\3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2,
\3)/

BUG=598897

Committed: https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92
Cr-Commit-Position: refs/heads/master@{#408745}
==========

[commit-bot: I haz the power, 2016-07-29 21:11:22]

Patchset 1 (id:??) landed as
https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92
Cr-Commit-Position: refs/heads/master@{#408745}

[Dirk Pranke, 2016-08-09 00:53:19]

lgtm (belatedly).