third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

index f5ed8444118f81e74fb974cd1b28451ee881fb22..a9264ebf8a122cd349bcaa7d34ab977226db0ddf 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py

@@ -107,13 +107,13 @@ class Command(object):

def check_arguments_and_execute(self, options, args, tool=None):

if len(args) < len(self.required_arguments):

- _log.error("%s required, %s provided. Provided: %s Required: %s\nSee '%s help %s' for usage." % (

+ _log.error("%s required, %s provided. Provided: %s Required: %s\nSee '%s help %s' for usage.",

pluralize("argument", len(self.required_arguments)),

pluralize("argument", len(args)),

"'%s'" % " ".join(args),

" ".join(self.required_arguments),

tool.name(),

- self.name))

+ self.name)

return 1

return self.execute(options, args, tool) or 0