third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

index a1f5bce23f4986366cf56e6a71c934758ccb8ba6..43e77ac4644922564aa27ce3859dd497eeb09b48 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

@@ -120,7 +120,7 @@ class PerfTest(object):

should_log = not self._port.get_option('profile')

if should_log and self._description:

- _log.info('DESCRIPTION: %s' % self._description)

+ _log.info('DESCRIPTION: %s', self._description)

results = {}

for metric_name in self._ordered_metrics_name:

@@ -151,9 +151,9 @@ class PerfTest(object):

median = sorted_values[middle] if len(sorted_values) % 2 else (sorted_values[middle - 1] + sorted_values[middle]) / 2

stdev = math.sqrt(square_sum / (len(sorted_values) - 1)) if len(sorted_values) > 1 else 0

- _log.info('RESULT %s= %s %s' % (test_name, mean, unit))

- _log.info('median= %s %s, stdev= %s %s, min= %s %s, max= %s %s' %

- (median, unit, stdev, unit, sorted_values[0], unit, sorted_values[-1], unit))

+ _log.info('RESULT %s= %s %s', test_name, mean, unit)

+ _log.info('median= %s %s, stdev= %s %s, min= %s %s, max= %s %s',

+ median, unit, stdev, unit, sorted_values[0], unit, sorted_values[-1], unit)

_description_regex = re.compile(r'^Description: (?P<description>.*)$', re.IGNORECASE)

_metrics_regex = re.compile(r'^(?P<metric>Time|Malloc|JS Heap):')

@@ -205,14 +205,14 @@ class PerfTest(object):

def run_failed(self, output):

if output.error:

- _log.error('error: %s\n%s' % (self.test_name(), output.error))

+ _log.error('error: %s\n%s', self.test_name(), output.error)

if output.text is None:

pass

elif output.timeout:

- _log.error('timeout: %s' % self.test_name())

+ _log.error('timeout: %s', self.test_name())

elif output.crash:

- _log.error('crash: %s' % self.test_name())

+ _log.error('crash: %s', self.test_name())

else:

return False