third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

index 23e966170fa62d921847794986ca5ca2186db22d..ebfde5449c6e8744e7b93595cdd7c778bbd9306c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

@@ -334,7 +334,7 @@ class Driver(object):

line = server_process.read_stdout_line(deadline)

if server_process.timed_out or server_process.has_crashed():

- _log.error('Failed to start the %s process: \n%s' % (server_process.name(), output))

+ _log.error('Failed to start the %s process: \n%s', server_process.name(), output)

return False

return True

@@ -389,7 +389,7 @@ class Driver(object):

pid = int(match.group(1)) if match else None

self._crashed_pid = pid

# FIXME: delete this after we're sure this code is working :)

- _log.debug('%s crash, pid = %s, error_line = %s' % (self._crashed_process_name, str(pid), error_line))

+ _log.debug('%s crash, pid = %s, error_line = %s', self._crashed_process_name, str(pid), error_line)

if error_line.startswith("#PROCESS UNRESPONSIVE - "):

self._subprocess_was_unresponsive = True

self._port.sample_process(self._crashed_process_name, self._crashed_pid)