Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2011 Google Inc. All rights reserved. 1 # Copyright (c) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 models = [] 76 models = []
77 for builder_name in builder_names: 77 for builder_name in builder_names:
78 model = TestExpectationsModel() 78 model = TestExpectationsModel()
79 models.append(model) 79 models.append(model)
80 80
81 expectations = factory.expectations_for_builder(builder_name) 81 expectations = factory.expectations_for_builder(builder_name)
82 82
83 # TODO(ojan): We should also skip bots that haven't uploaded recentl y, 83 # TODO(ojan): We should also skip bots that haven't uploaded recentl y,
84 # e.g. if they're >24h stale. 84 # e.g. if they're >24h stale.
85 if not expectations: 85 if not expectations:
86 _log.error("Can't load flakiness data for builder: %s" % builder _name) 86 _log.error("Can't load flakiness data for builder: %s", builder_ name)
87 continue 87 continue
88 88
89 for line in expectations.expectation_lines(only_ignore_very_flaky=Tr ue): 89 for line in expectations.expectation_lines(only_ignore_very_flaky=Tr ue):
90 # TODO(ojan): Find a way to merge specifiers instead of removing build types. 90 # TODO(ojan): Find a way to merge specifiers instead of removing build types.
91 # We can't just union because some specifiers will change the me aning of others. 91 # We can't just union because some specifiers will change the me aning of others.
92 # For example, it's not clear how to merge [ Mac Release ] with [ Linux Debug ]. 92 # For example, it's not clear how to merge [ Mac Release ] with [ Linux Debug ].
93 # But, in theory we should be able to merge [ Mac Release ] and [ Mac Debug ]. 93 # But, in theory we should be able to merge [ Mac Release ] and [ Mac Debug ].
94 line.specifiers = self._filter_build_type_specifiers(line.specif iers) 94 line.specifiers = self._filter_build_type_specifiers(line.specif iers)
95 model.add_expectation_line(line) 95 model.add_expectation_line(line)
96 96
(...skipping 13 matching lines...) Expand all
110 port = tool.port_factory.get() 110 port = tool.port_factory.get()
111 # Skip any tests which are mentioned in the dashboard but not in our che ckout: 111 # Skip any tests which are mentioned in the dashboard but not in our che ckout:
112 fs = tool.filesystem 112 fs = tool.filesystem
113 lines = [line for line in lines if fs.exists(fs.join(port.layout_tests_d ir(), line.path))] 113 lines = [line for line in lines if fs.exists(fs.join(port.layout_tests_d ir(), line.path))]
114 114
115 test_names = [line.name for line in lines] 115 test_names = [line.name for line in lines]
116 flakiness_dashboard_url = self.FLAKINESS_DASHBOARD_URL % ','.join(test_n ames) 116 flakiness_dashboard_url = self.FLAKINESS_DASHBOARD_URL % ','.join(test_n ames)
117 expectations_string = TestExpectations.list_to_string(lines) 117 expectations_string = TestExpectations.list_to_string(lines)
118 118
119 print self.OUTPUT % (self.HEADER, expectations_string, flakiness_dashboa rd_url) 119 print self.OUTPUT % (self.HEADER, expectations_string, flakiness_dashboa rd_url)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698