third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

index 7ef9875bf74587ea19e94d0bcf1299f10bb3883f..ab1f1a0b1575bba22b0d9a8e65c2eff4bbd6beae 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

@@ -245,7 +245,7 @@ class _Worker(multiprocessing.Process):

self._set_up_logging()

worker = self._worker

- _log.debug("%s starting" % self.name)

+ _log.debug("%s starting", self.name)

self._running = True

try:

@@ -260,7 +260,7 @@ class _Worker(multiprocessing.Process):

assert message.name == 'stop', 'bad message %s' % repr(message)

break

- _log.debug("%s exiting" % self.name)

+ _log.debug("%s exiting", self.name)

except Queue.Empty:

assert False, '%s: ran out of messages in worker queue.' % self.name

except KeyboardInterrupt:

@@ -297,10 +297,10 @@ class _Worker(multiprocessing.Process):

raise exception_type, exception_value, exception_traceback

if exception_type == KeyboardInterrupt:

- _log.debug("%s: interrupted, exiting" % self.name)

+ _log.debug("%s: interrupted, exiting", self.name)

stack_utils.log_traceback(_log.debug, exception_traceback)

else:

- _log.error("%s: %s('%s') raised:" % (self.name, exception_value.__class__.__name__, str(exception_value)))

+ _log.error("%s: %s('%s') raised:", self.name, exception_value.__class__.__name__, str(exception_value))

stack_utils.log_traceback(_log.error, exception_traceback)

# Since tracebacks aren't picklable, send the extracted stack instead.

stack = traceback.extract_tb(exception_traceback)