third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index a9be6b450600b1a6b7caea95a450c6f9ceb4777e..7dda2713a136d962d26d30dbdd9d047e1dc6927d 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -511,7 +511,7 @@ def _set_up_derived_options(port, options, args):

# to Port.

filesystem = port.host.filesystem

if not filesystem.isdir(filesystem.join(port.layout_tests_dir(), directory)):

- _log.warning("'%s' was passed to --pixel-test-directories, which doesn't seem to be a directory" % str(directory))

+ _log.warning("'%s' was passed to --pixel-test-directories, which doesn't seem to be a directory", str(directory))

else:

verified_dirs.add(directory)

@@ -568,13 +568,13 @@ def run(port, options, args, logging_stream, stdout):

_log.debug("Dashboard generated.")

_log.debug("")

- _log.debug("Testing completed, Exit status: %d" % run_details.exit_code)

+ _log.debug("Testing completed, Exit status: %d", run_details.exit_code)

# Temporary process dump for debugging windows timeout issues, see crbug.com/522396.

_log.debug("")

_log.debug("Process dump:")

for process in port.host.executive.process_dump():

- _log.debug("\t%s" % process)

+ _log.debug("\t%s", process)

return run_details