third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

index a8100ece63636df727176995266f4f0335f5ceba..eb63764b530cdf3d819d3a817b26b7bcd2b62c15 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

@@ -148,7 +148,7 @@ class Executive(object):

except OSError as e:

if e.errno == errno.EAGAIN:

if retries_left <= 0:

- _log.warn("Failed to kill pid %s. Too many EAGAIN errors." % pid)

+ _log.warning("Failed to kill pid %s. Too many EAGAIN errors.", pid)

continue

if e.errno == errno.ESRCH: # The process does not exist.

return

@@ -377,7 +377,7 @@ class Executive(object):

exit_code = process.wait()

if debug_logging:

- _log.debug('"%s" took %.2fs' % (self.command_for_printing(args), time.time() - start_time))

+ _log.debug('"%s" took %.2fs', self.command_for_printing(args), time.time() - start_time)

if return_exit_code:

return exit_code