third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index 5c173130ff6cf77d10793fa0c8f8489e5934b17f..13ab8c48421a7192ee3c639f94e183edf3799440 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -344,8 +344,8 @@ def summarize_results(port_obj, expectations, initial_results,

if scm:

results['chromium_revision'] = str(scm.commit_position(path))

else:

- _log.warn('Failed to determine chromium commit position for %s, '

- 'leaving "chromium_revision" key blank in full_results.json.'

- % path)

+ _log.warning('Failed to determine chromium commit position for %s, '

+ 'leaving "chromium_revision" key blank in full_results.json.',

+ path)

return results