third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

index 41bb16de21147d78f1348e5ac27a72f42c3f7b8d..08fafb2da28738acf0b2ea6f15aafee1a18e5f23 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

@@ -156,8 +156,7 @@ class DiffParser(object):

lines_changed = lines_changed_pattern.match(line)

if lines_changed:

if state != _DECLARED_FILE_PATH and state != _PROCESSING_CHUNK:

- _log.error('Unexpected line change without file path '

- 'declaration: %r' % line)

+ _log.error('Unexpected line change without file path declaration: %r', line)

old_diff_line = int(lines_changed.group('OldStartLine'))

new_diff_line = int(lines_changed.group('NewStartLine'))

state = _PROCESSING_CHUNK

@@ -178,6 +177,5 @@ class DiffParser(object):

# Nothing to do. We may still have some added lines.

pass

else:

- _log.error('Unexpected diff format when parsing a '

- 'chunk: %r' % line)

+ _log.error('Unexpected diff format when parsing a chunk: %r', line)

return files