third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_mock.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2009, Google Inc. All rights reserved.	1 # Copyright (c) 2009, Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 131 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142	142

143 def can_open_url(self):	143 def can_open_url(self):

144 try:	144 try:

145 webbrowser.get()	145 webbrowser.get()

146 return True	146 return True

147 except webbrowser.Error:	147 except webbrowser.Error:

148 return False	148 return False

149	149

150 def open_url(self, url):	150 def open_url(self, url):

151 if not self.can_open_url():	151 if not self.can_open_url():

152 _log.warn("Failed to open %s" % url)	152 _log.warning("Failed to open %s", url)

153 webbrowser.open(url)	153 webbrowser.open(url)

OLD	NEW