Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index 32a2f6d1d6a304ebd8068317b2f3fe7703840308..67ca8bce188b6127c091266b79da0dc5c264aa6c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -149,9 +149,9 @@ class Manager(object):
break
_log.info('')
- _log.info('Retrying %s, attempt %d of %d...' %
- (grammar.pluralize('unexpected failure', len(tests_to_retry)),
- retry_attempt, self._options.num_retries))
+ _log.info('Retrying %s, attempt %d of %d...',
+ grammar.pluralize('unexpected failure', len(tests_to_retry)),
+ retry_attempt, self._options.num_retries)
retry_results = self._run_tests(tests_to_retry,
tests_to_skip=set(),
@@ -186,8 +186,8 @@ class Manager(object):
exit_code = summarized_failing_results['num_regressions']
if exit_code > test_run_results.MAX_FAILURES_EXIT_STATUS:
- _log.warning('num regressions (%d) exceeds max exit status (%d)' %
- (exit_code, test_run_results.MAX_FAILURES_EXIT_STATUS))
+ _log.warning('num regressions (%d) exceeds max exit status (%d)',
+ exit_code, test_run_results.MAX_FAILURES_EXIT_STATUS)
exit_code = test_run_results.MAX_FAILURES_EXIT_STATUS
if not self._options.dry_run:
@@ -477,7 +477,7 @@ class Manager(object):
) if result.type != test_expectations.PASS]
def _write_json_files(self, summarized_full_results, summarized_failing_results, initial_results, running_all_tests):
- _log.debug("Writing JSON files in %s." % self._results_directory)
+ _log.debug("Writing JSON files in %s.", self._results_directory)
# FIXME: Upload stats.json to the server and delete times_ms.
times_trie = json_results_generator.test_timings_trie(initial_results.results_by_name.values())
@@ -533,11 +533,11 @@ class Manager(object):
if response.code == 200:
_log.debug("JSON uploaded.")
else:
- _log.debug("JSON upload failed, %d: '%s'" % (response.code, response.read()))
+ _log.debug("JSON upload failed, %d: '%s'", response.code, response.read())
else:
_log.error("JSON upload failed; no response returned")
except Exception as err:
- _log.error("Upload failed: %s" % err)
+ _log.error("Upload failed: %s", err)
def _copy_results_html_file(self, destination_path):
base_dir = self._port.path_from_webkit_base('LayoutTests', 'fast', 'harness')

Powered by Google App Engine
This is Rietveld 408576698