Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # Copyright (C) 2011 Apple Inc. All rights reserved. 3 # Copyright (C) 2011 Apple Inc. All rights reserved.
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 if options.pixel_test_directories: 504 if options.pixel_test_directories:
505 options.pixel_tests = True 505 options.pixel_tests = True
506 verified_dirs = set() 506 verified_dirs = set()
507 pixel_test_directories = options.pixel_test_directories 507 pixel_test_directories = options.pixel_test_directories
508 for directory in pixel_test_directories: 508 for directory in pixel_test_directories:
509 # FIXME: we should support specifying the directories all the ways w e support it for additional 509 # FIXME: we should support specifying the directories all the ways w e support it for additional
510 # arguments specifying which tests and directories to run. We should also move the logic for that 510 # arguments specifying which tests and directories to run. We should also move the logic for that
511 # to Port. 511 # to Port.
512 filesystem = port.host.filesystem 512 filesystem = port.host.filesystem
513 if not filesystem.isdir(filesystem.join(port.layout_tests_dir(), dir ectory)): 513 if not filesystem.isdir(filesystem.join(port.layout_tests_dir(), dir ectory)):
514 _log.warning("'%s' was passed to --pixel-test-directories, which doesn't seem to be a directory" % str(directory)) 514 _log.warning("'%s' was passed to --pixel-test-directories, which doesn't seem to be a directory", str(directory))
515 else: 515 else:
516 verified_dirs.add(directory) 516 verified_dirs.add(directory)
517 517
518 options.pixel_test_directories = list(verified_dirs) 518 options.pixel_test_directories = list(verified_dirs)
519 519
520 if options.run_singly: 520 if options.run_singly:
521 options.batch_size = 1 521 options.batch_size = 1
522 options.verbose = True 522 options.verbose = True
523 523
524 if not args and not options.test_list and options.smoke is None: 524 if not args and not options.test_list and options.smoke is None:
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug _rwt_logging) 561 bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug _rwt_logging)
562 bot_printer.print_results(run_details) 562 bot_printer.print_results(run_details)
563 stdout.flush() 563 stdout.flush()
564 564
565 _log.debug("Generating dashboard...") 565 _log.debug("Generating dashboard...")
566 gen_dash_board = DashBoardGenerator(port) 566 gen_dash_board = DashBoardGenerator(port)
567 gen_dash_board.generate() 567 gen_dash_board.generate()
568 _log.debug("Dashboard generated.") 568 _log.debug("Dashboard generated.")
569 569
570 _log.debug("") 570 _log.debug("")
571 _log.debug("Testing completed, Exit status: %d" % run_details.exit_code) 571 _log.debug("Testing completed, Exit status: %d", run_details.exit_code)
572 572
573 # Temporary process dump for debugging windows timeout issues, see crbug .com/522396. 573 # Temporary process dump for debugging windows timeout issues, see crbug .com/522396.
574 _log.debug("") 574 _log.debug("")
575 _log.debug("Process dump:") 575 _log.debug("Process dump:")
576 for process in port.host.executive.process_dump(): 576 for process in port.host.executive.process_dump():
577 _log.debug("\t%s" % process) 577 _log.debug("\t%s", process)
578 578
579 return run_details 579 return run_details
580 580
581 finally: 581 finally:
582 printer.cleanup() 582 printer.cleanup()
583 583
584 if __name__ == '__main__': 584 if __name__ == '__main__':
585 exit_code = main(sys.argv[1:], sys.stdout, sys.stderr) 585 exit_code = main(sys.argv[1:], sys.stdout, sys.stderr)
586 sys.exit(exit_code) 586 sys.exit(exit_code)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698