Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com) 2 # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com)
3 # Copyright (C) 2010 ProFUSION embedded systems 3 # Copyright (C) 2010 ProFUSION embedded systems
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 def check(self, patch_string, fs=None): 55 def check(self, patch_string, fs=None):
56 """Check style in the given patch.""" 56 """Check style in the given patch."""
57 fs = fs or FileSystem() 57 fs = fs or FileSystem()
58 patch_files = DiffParser(patch_string.splitlines()).files 58 patch_files = DiffParser(patch_string.splitlines()).files
59 59
60 # If the user uses git, checking subversion config file only once is eno ugh. 60 # If the user uses git, checking subversion config file only once is eno ugh.
61 call_only_once = True 61 call_only_once = True
62 62
63 for path, diff_file in patch_files.iteritems(): 63 for path, diff_file in patch_files.iteritems():
64 line_numbers = diff_file.added_or_modified_line_numbers() 64 line_numbers = diff_file.added_or_modified_line_numbers()
65 _log.debug('Found %s new or modified lines in: %s' % (len(line_numbe rs), path)) 65 _log.debug('Found %s new or modified lines in: %s', len(line_numbers ), path)
66 66
67 if not line_numbers: 67 if not line_numbers:
68 match = re.search("\s*png$", path) 68 match = re.search("\s*png$", path)
69 if match and fs.exists(path): 69 if match and fs.exists(path):
70 if call_only_once: 70 if call_only_once:
71 self._text_file_reader.process_file(file_path=path, line _numbers=None) 71 self._text_file_reader.process_file(file_path=path, line _numbers=None)
72 cwd = FileSystem().getcwd() 72 cwd = FileSystem().getcwd()
73 detection = SCMDetector(fs, Executive()).detect_scm_syst em(cwd) 73 detection = SCMDetector(fs, Executive()).detect_scm_syst em(cwd)
74 if detection.display_name() == "git": 74 if detection.display_name() == "git":
75 call_only_once = False 75 call_only_once = False
76 continue 76 continue
77 # Don't check files which contain only deleted lines 77 # Don't check files which contain only deleted lines
78 # as they can never add style errors. However, mark them as 78 # as they can never add style errors. However, mark them as
79 # processed so that we count up number of such files. 79 # processed so that we count up number of such files.
80 self._text_file_reader.count_delete_only_file() 80 self._text_file_reader.count_delete_only_file()
81 continue 81 continue
82 82
83 self._text_file_reader.process_file(file_path=path, line_numbers=lin e_numbers) 83 self._text_file_reader.process_file(file_path=path, line_numbers=lin e_numbers)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698