third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

index a783a5d372655aa11dbd98e09b5ddae2973f913d..efeaab08c377c938d89e138b179d621d3febe834 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

@@ -84,7 +84,7 @@ class MockExecutive(object):

if process_name_filter(process_name):

running_pids.append(process_pid)

- _log.info("MOCK running_pids: %s" % running_pids)

+ _log.info("MOCK running_pids: %s", running_pids)

return running_pids

def command_for_printing(self, args):

@@ -112,7 +112,7 @@ class MockExecutive(object):

input_string = ""

if input:

input_string = ", input=%s" % input

- _log.info("MOCK run_command: %s, cwd=%s%s%s" % (args, cwd, env_string, input_string))

+ _log.info("MOCK run_command: %s, cwd=%s%s%s", args, cwd, env_string, input_string)

output = "MOCK output of child process"

if self._should_throw_when_run.intersection(args):

@@ -144,14 +144,14 @@ class MockExecutive(object):

env_string = ""

if env:

env_string = ", env=%s" % env

- _log.info("MOCK popen: %s%s%s" % (args, cwd_string, env_string))

+ _log.info("MOCK popen: %s%s%s", args, cwd_string, env_string)

if not self._proc:

self._proc = MockProcess()

return self._proc

def call(self, args, **kwargs):

self.calls.append(args)

- _log.info('Mock call: %s' % args)

+ _log.info('Mock call: %s', args)

def run_in_parallel(self, commands):

assert len(commands)