third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

index 67a78885292aaff4ba36ba9c2141314de5165de9..9719f98e65a46dcd016d9e16c35902c2d5014a8a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

@@ -63,7 +63,7 @@ class RebaselineFromTryJobs(AbstractParallelRebaselineCommand):

if options.issue:

return options.issue

issue_number = self._git().get_issue_number()

- _log.debug('Issue number for current branch: %s' % issue_number)

+ _log.debug('Issue number for current branch: %s', issue_number)

if not issue_number.isdigit():

_log.error('No issue number given and no issue for current branch.')

return None

@@ -88,10 +88,10 @@ class RebaselineFromTryJobs(AbstractParallelRebaselineCommand):

def _builds_to_tests(self, issue_number):

"""Fetches a list of try bots, and for each, fetches tests with new baselines."""

- _log.debug('Getting results for Rietveld issue %d.' % issue_number)

+ _log.debug('Getting results for Rietveld issue %d.', issue_number)

try_jobs = latest_try_jobs(issue_number, self._try_bots(), self.web)

if not try_jobs:

- _log.debug('No try job results for builders in: %r.' % (self._try_bots(),))

+ _log.debug('No try job results for builders in: %r.', self._try_bots())

builds_to_tests = {}

for job in try_jobs:

test_results = self._unexpected_mismatch_results(job)