third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

index 68fee8f298e7438fa73b2a92e693af0de4b84348..20b021b75eba9a5d34ba0aa27dacbd20dab547f4 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

@@ -74,7 +74,7 @@ class DumpReaderMultipart(DumpReader):

try:

stack = self._host.executive.run_command(cmd, return_stderr=False)

except:

- _log.warning('Failed to execute "%s"' % ' '.join(cmd))

+ _log.warning('Failed to execute "%s"', ' '.join(cmd))

stack = None

finally:

self._host.filesystem.remove(temp_name)

@@ -104,8 +104,8 @@ class DumpReaderMultipart(DumpReader):

full_path = self._host.filesystem.join(self._build_dir, binary)

if not self._host.filesystem.exists(full_path):

result = False

- _log.error('Unable to find %s' % binary)

- _log.error(' at %s' % full_path)

+ _log.error('Unable to find %s', binary)

+ _log.error(' at %s', full_path)

if not result:

_log.error(" Could not find breakpad tools, unexpected crashes won't be symbolized")

@@ -136,7 +136,7 @@ class DumpReaderMultipart(DumpReader):

thread.start()

try:

for binary in self._binaries_to_symbolize():

- _log.debug(' Symbolizing %s' % binary)

+ _log.debug(' Symbolizing %s', binary)

full_path = self._host.filesystem.join(self._build_dir, binary)

cmd = [

self._path_to_generate_breakpad_symbols(),

@@ -147,7 +147,7 @@ class DumpReaderMultipart(DumpReader):

try:

self._host.executive.run_command(cmd)

except:

- _log.error('Failed to execute "%s"' % ' '.join(cmd))

+ _log.error('Failed to execute "%s"', ' '.join(cmd))

finally:

queue.put(None)

thread.join()