third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

index dd7b72253e3cca352e5415dca16502cdff2f7077..1b357ddf51aee4a3280983c4b3a8a96094a5615e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

@@ -41,7 +41,7 @@ def main(host, bot_test_expectations_factory, argv):

expectations_file = port.path_to_generic_test_expectations_file()

if not host.filesystem.isfile(expectations_file):

- _log.warn("Didn't find generic expectations file at: " + expectations_file)

+ _log.warning("Didn't find generic expectations file at: " + expectations_file)

return 1

remove_flakes_o_matic = RemoveFlakesOMatic(host,

@@ -104,7 +104,7 @@ class RemoveFlakesOMatic(object):

return False

if builder_name not in self._builder_results_by_path.keys():

- _log.error('Failed to find results for builder "%s"' % builder_name)

+ _log.error('Failed to find results for builder "%s"', builder_name)

return False

results_by_path = self._builder_results_by_path[builder_name]

@@ -196,7 +196,7 @@ class RemoveFlakesOMatic(object):

# This is not fatal since we may not need to check these

# results. If we do need these results we'll log an error later

# when trying to check against them.

- _log.warn('Downloaded results are missing results for builder "%s"' % builder_name)

+ _log.warning('Downloaded results are missing results for builder "%s"', builder_name)

continue

builder_results_by_path[builder_name] = (